-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected dApps: make right side of page-nav accomodate whatever we need #19934
Conversation
Jenkins BuildsClick to see older builds (22)
|
src/status_im/contexts/wallet/common/account_switcher/view.cljs
Outdated
Show resolved
Hide resolved
Thank you for the feature and clever approach. This method is better than mine in #19929. I'm gonna close my PR and chill |
To whoever will be testing this: need to make sure that |
85% of end-end tests have passed
Failed tests (6)Click to expandClass TestWalletOneDevice:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (44)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestWalletOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
@alwx |
Thanks for your work @alwx! I couldn't find any regression, PR can be merged. |
fixes #19867
Summary
Updates
page-nav
to make it possible to accomodate different types of content on the right side of it — in this paticular case it means mixingaccount-switcher
and regular buttons but the possible options are endless.Also adds a button to open connected dapps screen + opens a very basic screen with just "Connected dApps" title. The rest will be handled in this issue: #19839
(all that is hidden behind the
wallet-connect
feature flag)Documentation change PR (review please): https://github.com/status-im/status.im/pull/xxx
Platforms
Areas that maybe impacted
Functional
status: ready